Jstzd: add rollup build script and spawn rollup in jstzd #670

ryutamago · 2024-11-17T10:49:30Z

Context

NOTE:
The jstz kernel rollup seems to not process the block in the CI (i suppose some issue with nix.flake)
the test works fine with the default nix settings nix flake check.
I also replaced the jstz kernel with the toy rollup kernel and that worked with the nix.flake

Description

There are two parts in this PR:

add a build script to build the rollup preimages / installer
a. Modified the MakeFile so that the kernel.wasm is copied to crates/jstzd/
b. Add build.rs that 1) stores the rollup kernel_installer.hex, preimages/ and parameters_ty.json to OUT_DIR. 2) generate a path getter file (jstz_rollup_path.rs) to access the path of 1
add rollup to the jstzd server

Manually testing the PR

added rollup to the jstzd integration test.

make build
cargo test --package jstzd --test jstzd_test

nix flake check

crates/jstzd/build_config.rs

crates/jstzd/build.rs

crates/jstzd/src/task/jstzd.rs

crates/jstzd/build.rs

crates/jstzd/src/task/jstzd.rs

crates/jstzd/src/task/utils.rs

insatller

Makefile

crates/jstzd/tests/jstzd_test.rs

zcabter · 2024-11-21T13:33:45Z

~~Btw, you should add ./resources/jstz_rollup and jstz_rollup_path.rs to the .gitignore and include these files as part of the jstzd package in Cargo.toml~~

codecov · 2024-11-21T23:28:42Z

Codecov Report

Attention: Patch coverage is 79.71014% with 14 lines in your changes missing coverage. Please review.

Project coverage is 47.89%. Comparing base (5647e1c) to head (8e7f0c0).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
crates/jstzd/src/task/jstzd.rs	79.06%	1 Missing and 8 partials ⚠️
crates/jstzd/src/task/utils.rs	72.72%	0 Missing and 3 partials ⚠️
crates/octez/src/async/rollup.rs	0.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
crates/jstzd/src/config.rs	`96.79% <100.00%> (+0.09%)`	⬆️
crates/jstzd/src/lib.rs	`83.33% <ø> (-8.34%)`	⬇️
crates/octez/src/async/rollup.rs	`95.00% <0.00%> (+5.75%)`	⬆️
crates/jstzd/src/task/utils.rs	`89.62% <72.72%> (-1.96%)`	⬇️
crates/jstzd/src/task/jstzd.rs	`76.05% <79.06%> (+0.13%)`	⬆️

... and 5 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5647e1c...8e7f0c0. Read the comment docs.

crates/jstzd/tests/jstzd_test.rs

crates/jstzd/build.rs

file_path

crates/jstzd/src/config.rs

crates/jstzd/src/task/jstzd.rs

crates/jstzd/tests/jstzd_test.rs

ryutamago force-pushed the leounoki-jstz-164/spawn-rollup-3 branch from 9092c37 to 24607d3 Compare November 17, 2024 19:08

zcabter self-assigned this Nov 18, 2024

ryutamago commented Nov 18, 2024

View reviewed changes

crates/jstzd/build_config.rs Outdated Show resolved Hide resolved

ryutamago force-pushed the leounoki-jstz-164/spawn-rollup-3 branch from 24607d3 to 0418f5f Compare November 21, 2024 10:53

ryutamago mentioned this pull request Nov 21, 2024

feat(jstzd): spwan rollup in jstzd server #666

Closed

ryutamago changed the title ~~[WIP] build rollup preimages and spawn rollup~~ Jstzd: add build.rs fro the rollup and spawn rollup in jstzd Nov 21, 2024

ryutamago force-pushed the leounoki-jstz-164/spawn-rollup-3 branch from 0418f5f to a88546d Compare November 21, 2024 11:24

ryutamago assigned ryutamago and unassigned zcabter Nov 21, 2024